Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix format issue #937

Merged
merged 14 commits into from
Jan 30, 2024
Merged

fix format issue #937

merged 14 commits into from
Jan 30, 2024

Conversation

strengejacke
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 275 lines in your changes are missing coverage. Please review.

Comparison is base (0d5fa75) 58.15% compared to head (32dd157) 59.19%.
Report is 20 commits behind head on main.

❗ Current head 32dd157 differs from pull request most recent head 51546ad. Consider uploading reports for the commit 51546ad to get more accurate results

Files Patch % Lines
R/print_table.R 0.00% 80 Missing ⚠️
R/cluster_analysis.R 30.76% 45 Missing ⚠️
R/utils_pca_efa.R 17.50% 33 Missing ⚠️
R/n_factors.R 46.15% 14 Missing ⚠️
R/methods_glmmTMB.R 53.57% 13 Missing ⚠️
R/reduce_parameters.R 0.00% 12 Missing ⚠️
R/utils_format.R 73.91% 12 Missing ⚠️
R/cluster_meta.R 0.00% 9 Missing ⚠️
R/extract_parameters.R 91.01% 8 Missing ⚠️
R/methods_nestedLogit.R 60.00% 8 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   58.15%   59.19%   +1.04%     
==========================================
  Files         186      187       +1     
  Lines       13959    14092     +133     
==========================================
+ Hits         8118     8342     +224     
+ Misses       5841     5750      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke
Copy link
Member Author

@IndrajeetPatil The tests repeatedly complain about

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-model_parameters.aov.R:59:3'): model_parameters.anova ──────────
<rlib_error_package_not_found/rlang_error/error/condition>
Error in `skip_if_offline()`: The package "curl" is required.
Backtrace:
    ▆
 1. └─testthat::skip_if_offline() at test-model_parameters.aov.R:59:3
 2.   └─rlang::check_installed("curl")

Do I have to add curl to the description file, or can this be fixed in the GHA files?

@strengejacke strengejacke merged commit 8869964 into main Jan 30, 2024
11 of 24 checks passed
@strengejacke strengejacke deleted the fix_format branch January 30, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant